Uploaded image for project: 'Observium'
  1. Observium
  2. OBS-515

Device App page highlights all navbar links of same app type

Details

    • Bug
    • Resolution: Fixed
    • Trivial
    • None
    • None
    • None
    • None

    Description

      If there are multiple instances of an application type for a device, the Apps page per device will set the navbar link to active on all links of that application type.

      Current Behavior:

      Expected Behavior:

      apps.inc.php.patch resolves issue.

      Attachments

        1. current-behavior.png
          97 kB
          Mikey
        2. expected-behavior.png
          69 kB
          Mikey

        Activity

          [OBS-515] Device App page highlights all navbar links of same app type
          adama Adam Armstrong added a comment -

          how come there's an instance with no instance name?

          adama Adam Armstrong added a comment - how come there's an instance with no instance name?
          highonmikey Mikey added a comment -

          Reviewed it since I'm not 330am tired. Actually seems fine, 003 is slightly better code, though. Added comments in there so you know wtf I'm doing.

          http://i.imgur.com/hiF98rO.png

          highonmikey Mikey added a comment - Reviewed it since I'm not 330am tired. Actually seems fine, 003 is slightly better code, though. Added comments in there so you know wtf I'm doing. http://i.imgur.com/hiF98rO.png
          highonmikey Mikey added a comment -

          Well, apps_inc_php-002.patch does what you say it should do. Seems I took kind of a roundabout way to get there. It's 03:30, though, so this might have an extra topping of tarded. I REGRET NOTHING.

          highonmikey Mikey added a comment - Well, apps_inc_php-002.patch does what you say it should do. Seems I took kind of a roundabout way to get there. It's 03:30, though, so this might have an extra topping of tarded. I REGRET NOTHING.
          adama Adam Armstrong added a comment - - edited

          This should produce a dropdown menu with the selected type in brackets liek :

          [ MSSQL (Derp) ]
          --> [ Derp ]
          --> [ Uberderp ]

          Navbar code can do this currently, I thought I had already done it, but perhaps i dreamt it. I don't actually have any applications with multiple instances to test, though.

          adama Adam Armstrong added a comment - - edited This should produce a dropdown menu with the selected type in brackets liek : [ MSSQL (Derp) ] --> [ Derp ] --> [ Uberderp ] Navbar code can do this currently, I thought I had already done it, but perhaps i dreamt it. I don't actually have any applications with multiple instances to test, though.

          People

            adama Adam Armstrong
            highonmikey Mikey
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: