Can't add graph to dashboard

Yes! After updating to r10632 it is working, confirmed!

This is definitely working now, and the problem you describe is what I already found and fixed. The code that caused it no longer exists.

Line 160 of html/pages/graphs.inc.php should be : 

if(isset($vars['dash_add']) && dashboard_exists($vars['dash_add']))

Another observation: On the system where it fails, I can in fact add graphs to the default dashboard, but not to others. The default dashboard is number 1, the others are numbers 5 and 7. (Some previously used dashboards created for testing had been deleted however it appears the numbering is maintained.)

The other system (where it always works), has the same three dashboards (names and contents), but they are numbered 1, 2, 3 sequentially.

Is this case perhaps related to dashboard numbering? Can I. by chance, reset the dashboard numbering to go sequentially again?

I am afraid it doesn't. I have updated to r10630 but no change.

I tried the same on another r106*25* Observium (different server), and there it worked fine. I have upgraded this to r106*30* as well and it still works. Indeed I am seeing the popup "Graph widget added to dashboard." on light blue background which I am not seeing on above mentioned system at all. So it seems there is a subtle difference between the two systems (they should be otherwise identical, same OS, same settings, just residing on different parts of the world)? Is there any logging where I can see how and where it fails? Is the missing pop-up perhaps something to look into?

I had to track down another html issue with the widget toolbar. It should work now.

Was caused by me using an array index to check if dash_id existed, which always returned the last dashboard as not existing!

Updated to r10625. Created a new blank dashboard - didn't work either.

Aha, this is a different issue. For me it only seems to want to add to the first dashboard, let me find out why!

Doesn't work, the graph in question isn't added to the dashboard (with unused widgets removed of course).

I've removed the confusing/unhelpful ui elements in r10625.

The process to add a graph widget is just to add it directly to the required dashboard from the graphs page, no need to add a blank graph widget first.

You can still add a graph by just clicking the entry for the dashboard name. The menu no longer extends because of some changes to allow the menu to scroll, breaking the extension.

CSS. It's shit.