Uploaded image for project: 'Observium'
  1. Observium
  2. OBS-2885

Papouch sensors not working after upgrade

Details

    • Bug
    • Resolution: Fixed
    • Minor
    • None
    • Professional Edition
    • Discovery, Poller

    Description

      After upgrade to 19.1.9661 I have an issue with sensors on Papouch devices.

      Before upgrade, the temperature sensor was working.

      Output of {{./discovery -h papouch -d }}is attached (with redacted domain name)

      Attachments

        Activity

          [OBS-2885] Papouch sensors not working after upgrade

          That because you use stable branch, all changes by first going to rolling (trunk).
          Wait for next stable update or switch to trunk.

          landy Mike Stupalov added a comment - That because you use stable branch, all changes by first going to rolling (trunk). Wait for next stable update or switch to trunk.
          Halenka Michal added a comment -

          Thank you Mike,
          But so far it is still not working.

          I did those changes, but even after few runs of ./discovery.php -h 63 and few days of waiting there are still no informations about temperature.

          Although when I run snmpwalk, I can get it via MIB that seems to be included in observium:

          #  snmpwalk -v1 -c raH5I7tsa0pJ 192.168.1.60 1.3.6.1.4.1.18248
          SNMPv2-SMI::enterprises.18248.16.1.1.0 = INTEGER: 194
          SNMPv2-SMI::enterprises.18248.16.1.2.0 = STRING: "+19.4 C"
          SNMPv2-SMI::enterprises.18248.16.1.3.0 = STRING: "Quido-CRA"
          SNMPv2-SMI::enterprises.18248.16.1.4.0 = Hex-STRING: BC 
          SNMPv2-SMI::enterprises.18248.16.2.1.1.1.1 = INTEGER: 1
          SNMPv2-SMI::enterprises.18248.16.2.1.1.1.2 = INTEGER: 1
          ......... shortened output .............
          SNMPv2-SMI::enterprises.18248.16.4.1.1.5.3 = INTEGER: 0
          End of MIB
          

          Halenka Michal added a comment - Thank you Mike, But so far it is still not working. I did those changes, but even after few runs of ./discovery.php -h 63 and few days of waiting there are still no informations about temperature. Although when I run snmpwalk, I can get it via MIB that seems to be included in observium: # snmpwalk -v1 -c raH5I7tsa0pJ 192.168.1.60 1.3.6.1.4.1.18248 SNMPv2-SMI::enterprises.18248.16.1.1.0 = INTEGER: 194 SNMPv2-SMI::enterprises.18248.16.1.2.0 = STRING: "+19.4 C" SNMPv2-SMI::enterprises.18248.16.1.3.0 = STRING: "Quido-CRA" SNMPv2-SMI::enterprises.18248.16.1.4.0 = Hex-STRING: BC SNMPv2-SMI::enterprises.18248.16.2.1.1.1.1 = INTEGER: 1 SNMPv2-SMI::enterprises.18248.16.2.1.1.1.2 = INTEGER: 1 ......... shortened output ............. SNMPv2-SMI::enterprises.18248.16.4.1.1.5.3 = INTEGER: 0 End of MIB

          for you, this clean svn code:

          cd /opt/observium
          svn rm --force includes/discovery/sensors/papouch-smi.inc.php
          svn revert includes/definitions/os.inc.php
          svn up
          

          landy Mike Stupalov added a comment - for you, this clean svn code: cd /opt/observium svn rm --force includes/discovery/sensors/papouch-smi.inc.php svn revert includes/definitions/os.inc.php svn up

          Fixed in r9678.

          ok, just added support for your sensors.
          now you can remove your self created code.

          landy Mike Stupalov added a comment - Fixed in r9678. ok, just added support for your sensors. now you can remove your self created code.

          Halenka.. you understand me?
          Someone in your surroundings self-developed support for your device and sensors.
          This is not our code. We can't fix that without see what you do with code.

          We changed some internal functions for sensors discovery, that why (probably) your code stopped working.
          If you make and attach patch file (as I written before), than I will try add support for your sensors to main code.

          landy Mike Stupalov added a comment - Halenka .. you understand me? Someone in your surroundings self-developed support for your device and sensors. This is not our code. We can't fix that without see what you do with code. We changed some internal functions for sensors discovery, that why (probably) your code stopped working. If you make and attach patch file (as I written before), than I will try add support for your sensors to main code.
          Halenka Michal added a comment -

          As far as observium documentation says, Papouch environmental sensors are supported. Therefore, (because I don't trust this obsolete leftover code from one of my predecessors) I've decided to get upstream version first, and then maybe apply some changes.

          Sadly enough, I am not able to get this working. I've moved ancient code to some backup files, and refetched them from SVN, but I still can't see temperature graph on my papouch devices.

          # svn status -u
          ? muj.patch
          ? html/images/login.png-orig
          ? html/includes/jpgraph
          ? html/includes/navbar-custom.inc.php-old
          M 9675 includes/defaults.inc.php
          ? includes/definitions/os.inc.php-new
          ? includes/definitions/os.inc.php-pre20190118
          ? includes/definitions/os.inc.php-work
          ? includes/definitions/rrdtypes.inc.php-pre20190118
          ? includes/discovery/os/papouch.inc.php-pre20190118
          A + - includes/discovery/sensors/papouch-smi.inc.php
          ? includes/discovery/sensors/papouch-smi.inc.php-pre20190118
          Status against revision: 9675
          # svn diff includes/discovery/sensors/papouch-smi.inc.php
          #

          Halenka Michal added a comment - As far as observium documentation says, Papouch environmental sensors are supported. Therefore, (because I don't trust this obsolete leftover code from one of my predecessors) I've decided to get upstream version first, and then maybe apply some changes. Sadly enough, I am not able to get this working. I've moved ancient code to some backup files, and refetched them from SVN, but I still can't see temperature graph on my papouch devices. # svn status -u ? muj.patch ? html/images/login.png-orig ? html/includes/jpgraph ? html/includes/navbar-custom.inc.php-old M 9675 includes/defaults.inc.php ? includes/definitions/os.inc.php-new ? includes/definitions/os.inc.php-pre20190118 ? includes/definitions/os.inc.php-work ? includes/definitions/rrdtypes.inc.php-pre20190118 ? includes/discovery/os/papouch.inc.php-pre20190118 A + - includes/discovery/sensors/papouch-smi.inc.php ? includes/discovery/sensors/papouch-smi.inc.php-pre20190118 Status against revision: 9675 # svn diff includes/discovery/sensors/papouch-smi.inc.php #

          just you have some local changes.
          if you was made it by self, you can send this as patch:

          cd /opt/observium
          svn add includes/discovery/os/papouch.inc.php
          svn diff includes/definitions/os.inc.php includes/discovery/sensors/papouch-smi.inc.php includes/discovery/os/papouch.inc.php > /tmp/papouch-smi.patch

          and attach this file papouch-smi.patch

          landy Mike Stupalov added a comment - just you have some local changes. if you was made it by self, you can send this as patch: cd /opt/observium svn add includes/discovery/os/papouch.inc.php svn diff includes/definitions/os.inc.php includes/discovery/sensors/papouch-smi.inc.php includes/discovery/os/papouch.inc.php > /tmp/papouch-smi.patch and attach this file papouch-smi.patch
          Halenka Michal added a comment - - edited

          I can see where you are heading to.

          It is probable that this observium installation (which I inherited) had some custom local changes for papouch in the time when it was not fully supported by observium.

          Here is the output:

          1. svn status /opt/observium
            ? /opt/observium/html/images/login.png-orig
            ? /opt/observium/html/includes/jpgraph
            ? /opt/observium/html/includes/navbar-custom.inc.php-old
            M /opt/observium/includes/defaults.inc.php
            M /opt/observium/includes/definitions/os.inc.php
            ? /opt/observium/includes/definitions/os.inc.php-new
            ? /opt/observium/includes/definitions/os.inc.php-work
            M /opt/observium/includes/definitions/rrdtypes.inc.php
            ? /opt/observium/includes/discovery/os/papouch.inc.php
            A + /opt/observium/includes/discovery/sensors/papouch-smi.inc.php
            M /opt/observium/includes/polling/applications/ceph.inc.php}}

          I guess I should somehow get rid of /opt/observium/includes/discovery/os/papouch.inc.php and "refetch" /opt/observium/includes/discovery/sensors/papouch-smi.inc.php am I correct?

          Halenka Michal added a comment - - edited I can see where you are heading to. It is probable that this observium installation (which I inherited) had some custom local changes for papouch in the time when it was not fully supported by observium. Here is the output: svn status /opt/observium ? /opt/observium/html/images/login.png-orig ? /opt/observium/html/includes/jpgraph ? /opt/observium/html/includes/navbar-custom.inc.php-old M /opt/observium/includes/defaults.inc.php M /opt/observium/includes/definitions/os.inc.php ? /opt/observium/includes/definitions/os.inc.php-new ? /opt/observium/includes/definitions/os.inc.php-work M /opt/observium/includes/definitions/rrdtypes.inc.php ? /opt/observium/includes/discovery/os/papouch.inc.php A + /opt/observium/includes/discovery/sensors/papouch-smi.inc.php M /opt/observium/includes/polling/applications/ceph.inc.php}} I guess I should somehow get rid of /opt/observium/includes/discovery/os/papouch.inc.php and "refetch" /opt/observium/includes/discovery/sensors/papouch-smi.inc.php am I correct?

          we support papouch devices and sensors.. but not the ones that I see in your debug.
          that why I not know how fix your issue.

          Show output for:

          svn status /opt/observium

          landy Mike Stupalov added a comment - we support papouch devices and sensors.. but not the ones that I see in your debug. that why I not know how fix your issue. Show output for: svn status /opt/observium
          Halenka Michal added a comment -

          Thank you for your quick response.

          This seems as not our code used (local changes).

          Yes it it possible that there are some local changes.

          We not have definitions and/or code for sensors by Papouch-SMI MIB.

          I found it listed here [https://docs.observium.org/supported_devices/#papouch-environmental-sensors|here], so I guessed that there is some official support.

           

          Would you mind to clarify if the link is correct about sensor support (and I should drop my local changes), or if observium is really not supporting papouch temperature sensor, and I should keep and modify my locall changes?

          Thank you

          Michal

           

           

          Halenka Michal added a comment - Thank you for your quick response. This seems as not our code used (local changes). Yes it it possible that there are some local changes. We not have definitions and/or code for sensors by Papouch-SMI MIB. I found it listed here [https://docs.observium.org/supported_devices/#papouch-environmental-sensors|here] , so I guessed that there is some official support.   Would you mind to clarify if the link is correct about sensor support (and I should drop my local changes), or if observium is really not supporting papouch temperature sensor, and I should keep and modify my locall changes? Thank you Michal    

          People

            landy Mike Stupalov
            Halenka Michal
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: