Uploaded image for project: 'Observium'
  1. Observium
  2. OBS-266

postfix mailgraph en qshape combined to postfix app

Details

    • Improvement
    • Resolution: Won't Fix
    • Minor
    • None
    • None
    • None

    Description

      Patch to combine both postfix_mailgraph and postfix_qshape to one application postfix.

      Attachments

        Activity

          [OBS-266] postfix mailgraph en qshape combined to postfix app

          There is a better way to do this btw:

          • 2 agent scripts, using <<<app-postfix-qshape>>> adn <<<app-postfix-mailgraph>>> as headers
          • These are parsed by the app system as "app postfix", so postfix.inc can handle both
          • They can be grouped as 1 app in the web interface then (however, I guess we'll have draw errors on graphs if only 1 of the 2 agent scripts is installed, currently)

          But backwards compatibility is very much needed.
          And those if hacks in unix-agent.inc.php are NOT supposed to be there, let alone adding more to them - the agent scripts should prefix app- themselves in the headers.

          sid3windr Tom Laermans added a comment - There is a better way to do this btw: 2 agent scripts, using <<<app-postfix-qshape>>> adn <<<app-postfix-mailgraph>>> as headers These are parsed by the app system as "app postfix", so postfix.inc can handle both They can be grouped as 1 app in the web interface then (however, I guess we'll have draw errors on graphs if only 1 of the 2 agent scripts is installed, currently) But backwards compatibility is very much needed. And those if hacks in unix-agent.inc.php are NOT supposed to be there, let alone adding more to them - the agent scripts should prefix app- themselves in the headers.

          I don't see a real reason to combine them, but more importantly: there is 0.0 backward compatibility in this patch...

          I was in fact just looking for the qshape code, apparently we ship an agent script but don't have Observium-side handling for this, so that part does seem useful

          The mailgraph app is afaik not displaying correct data (unrelated to this patch).

          sid3windr Tom Laermans added a comment - I don't see a real reason to combine them, but more importantly: there is 0.0 backward compatibility in this patch... I was in fact just looking for the qshape code, apparently we ship an agent script but don't have Observium-side handling for this, so that part does seem useful The mailgraph app is afaik not displaying correct data (unrelated to this patch).

          mailgraph is separate to postfix. qshape is part of postfix. These things are separate, so I'm not sure it's a good idea to force them to be merged.

          adama Adam Armstrong added a comment - mailgraph is separate to postfix. qshape is part of postfix. These things are separate, so I'm not sure it's a good idea to force them to be merged.

          People

            sid3windr Tom Laermans
            btoonk Bas Toonk
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: