Uploaded image for project: 'Observium'
  1. Observium
  2. OBS-1443

better parsing hardware and features for D-Link switches

Details

    • Improvement
    • Resolution: Fixed
    • Minor
    • None
    • Community Edition
    • Poller

    Description

      I collect big different D-Link swiches.
      And I write a better regexp for parsing hardware, features and version from sysDescr.

      connected with OBSERVIUM-1292

      Attachments

        Issue Links

          relates to

          Bug - A problem which impairs or prevents the functions of the product. OBS-2495 Don't write OS Version of switches D-Link

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed

          Activity

            [OBS-1443] better parsing hardware and features for D-Link switches
            landy Mike Stupalov added a comment -

            Worked, don't worry 

            if (preg_match('/^(\d+\.)+[\w\-]+$/', $matches['features']))

            landy Mike Stupalov added a comment - Worked, don't worry if (preg_match('/^(\d+\.)+[\w\-]+$/', $matches['features']))
            mtivi Martyushev Tim added a comment -

            landy check your regexp on on sysDescr from dlink.sysDescr.list in attached files
            I think that does not work for 

            DES-1210-28/ME          6.07.B004


            or 

            DGS-1224T                                4.21.02

            mtivi Martyushev Tim added a comment - landy check your regexp on on sysDescr from dlink.sysDescr.list in attached files I think that does not work for DES-1210-28/ME 6.07.B004 or DGS-1224T 4.21.02
            mtivi Martyushev Tim added a comment -

            my version is more specific...
            And in some models I can detect version

            mtivi Martyushev Tim added a comment - my version is more specific... And in some models I can detect version
            landy Mike Stupalov added a comment -

            Fixed in r6982.

            But I use other regexp:

            /^(?:dlink |d-link )?(?<hardware>[a-z]+\-\d+[\w\/-]+) +(?<features>.+)/i

            landy Mike Stupalov added a comment - Fixed in r6982. But I use other regexp: /^(?:dlink |d-link )?(?<hardware>[a-z]+\-\d+[\w\/-]+) +(?<features>.+)/i

            People

              landy Mike Stupalov
              mtivi Martyushev Tim
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: