1. For sensor state definitions recomended use types with '-state' at end:
-$config['sensor_states']['steelhead-system-health']
|
+$config['sensor_states']['steelhead-system-state']
|
|
-$config['sensor_states']['steelhead-service-status']
|
+$config['sensor_states']['steelhead-service-state']
|
2. In snmp*() functions always (if possible) use explicit indication MIB and named oids:
-$value = snmp_get($device, $oid, "-Oqv", "", mib_dirs('riverbed'));
|
+$value = snmp_get($device, "optServiceStatus.0", "-Oqv", "STEELHEAD-MIB", mib_dirs('riverbed'));
|
3. Numeric oids only if named oids impossible!
4. For convert state names to values use state_string_to_numeric():
+$value = state_string_to_numeric('steelhead-service-state', $value);
|
5. Attach debug output for discovery devices (tho oses):
./discovery.php -d -h <riverbed_device>
|
./discovery.php -d -h <zeustm_device>
|
6. About @copyright, you should accept Observium License, in copyright will always be:
@copyright (C) 2006-2014 Adam Armstrong
|
If this is not possible, we will not accept the code in the main base.
Added in r5980.