Uploaded image for project: 'Observium'
  1. Observium
  2. OBS-800

Allow syslog and eventlog to be set side-by-side on frontpage

Details

    Description

      This patch allows the admin to configure the eventlog and the syslog on the frontpage to be displayed side-by-side. This is useful when you have a wide monitor and/or you also have many devices alerting at once (and want to continue to be able to see some logs without scrolling as on a standalone dashboard).

      Enable this option by setting

      $config['splitlog'] = TRUE;

      in config.php.
      If you do not have both syslog and eventlog turned on they will continue to display full width.

      I have attached both the patch and a screenshot of the resulting display.

      Attachments

        Activity

          [OBS-800] Allow syslog and eventlog to be set side-by-side on frontpage
          adama Adam Armstrong added a comment -

          Committed in 5478.

          Thanks!

          adama Adam Armstrong added a comment - Committed in 5478. Thanks!
          slm4996 Solomon Seal added a comment -

          Here is an alternative version 3 of the patch, this one also uses only the new function in html/pages/front/default.php but instead of hijacking syslog and eventlog it is it's own log type.
          Take a look at both, I think I like this option, much cleaner implementation and better fits the coding styles of observium.

          slm4996 Solomon Seal added a comment - Here is an alternative version 3 of the patch, this one also uses only the new function in html/pages/front/default.php but instead of hijacking syslog and eventlog it is it's own log type. Take a look at both, I think I like this option, much cleaner implementation and better fits the coding styles of observium.
          slm4996 Solomon Seal added a comment -

          New screenshot attached.

          slm4996 Solomon Seal added a comment - New screenshot attached.
          slm4996 Solomon Seal added a comment -

          FYI, This was, once again, a clean patch based on r5340 and not an incremental patch.

          slm4996 Solomon Seal added a comment - FYI, This was, once again, a clean patch based on r5340 and not an incremental patch.
          slm4996 Solomon Seal added a comment -

          Here it is, patch version 3. This one uses your "short" logging format and only alters the html/pages/front/default.php and includes/default.inc.php files.

          I opted for a very different approach, but I think short of fully implementing a third log type this is the best option.

          slm4996 Solomon Seal added a comment - Here it is, patch version 3. This one uses your "short" logging format and only alters the html/pages/front/default.php and includes/default.inc.php files. I opted for a very different approach, but I think short of fully implementing a third log type this is the best option.
          adama Adam Armstrong added a comment -

          note that we already have a narrow syslog/eventlog format, it's used on the device overview pages

          adama Adam Armstrong added a comment - note that we already have a narrow syslog/eventlog format, it's used on the device overview pages
          adama Adam Armstrong added a comment -

          three lines tall is not an improvement

          adama Adam Armstrong added a comment - three lines tall is not an improvement
          slm4996 Solomon Seal added a comment -

          What about doing something like:

          2014_04_16 12:55:39
          aruba-master
          Warning (4)          		 AUTHMGR : <132094> <WARN> <Aruba7210 10.100.1.3> MIC failed in WPA2 Key Message 2 from Station c8:d1:0b:fa:9a:96 00:24:6c:06:41:e8 Spurlock-2nd-Room-226

          For the layout when in side by side mode?

          slm4996 Solomon Seal added a comment - What about doing something like: 2014_04_16 12:55:39 aruba-master Warning (4) AUTHMGR : <132094> <WARN> <Aruba7210 10.100.1.3> MIC failed in WPA2 Key Message 2 from Station c8:d1:0b:fa:9a:96 00:24:6c:06:41:e8 Spurlock-2nd-Room-226 For the layout when in side by side mode?
          slm4996 Solomon Seal added a comment -

          While I am working on V3 I will go ahead and remove the ternary operators from the existing code as I go, there are still one or two in each of the original functions.

          slm4996 Solomon Seal added a comment - While I am working on V3 I will go ahead and remove the ternary operators from the existing code as I go, there are still one or two in each of the original functions.
          slm4996 Solomon Seal added a comment -

          I can come up with a different layout, and I will certainly respect the decision to stop using ternary operators and will refactor appropriately.

          However in use cases like these where they fit so logically into the flow of the code and don't, much?, impact readability/understandability of the code that it almost hurts to expand them out.

          slm4996 Solomon Seal added a comment - I can come up with a different layout, and I will certainly respect the decision to stop using ternary operators and will refactor appropriately. However in use cases like these where they fit so logically into the flow of the code and don't, much?, impact readability/understandability of the code that it almost hurts to expand them out.

          People

            landy Mike Stupalov
            slm4996 Solomon Seal
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: