Uploaded image for project: 'Observium'
  1. Observium
  2. OBS-766

Various fixes and cleanups from HHVM

Details

    • Bug
    • Resolution: Fixed
    • Major
    • None
    • None
    • Billing
    • r5156

    Description

      I'm attaching a patch to fix and cleanup various items found by HHVM. Most of these changes are trivial, except for the last one – fix getRates().

      • includes/discovery/functions.inc.php
        • Fix reference to sensor_id and add global $debug in check_valid_sensors().
      • includes/functions.php
        • Make $snmpver an optional parameter on add_device() since it can be empty when discovering devices.
      • poll-billing.php
        • Add global $options to poll_bill().
      • includes/rewrites.php
        • Fix reference to the number of entities in humanize_alert_check().
        • Remove invalid extra parameter to format_timestamp().
      • includes/billing.php
        • Add global $device to getValues().
        • Quote array keys instead of using constant-style bare words in getLastPortCounter() and getLastMeasurement().
        • Fix variable naming bug in getRates(). How did this go unnoticed?

      Attachments

        Activity

          [OBS-766] Various fixes and cleanups from HHVM
          landy Mike Stupalov made changes -
          Workflow Original: classic default workflow [ 11559 ] New: Observium workflow [ 14064 ]
          adama Adam Armstrong made changes -
          Resolution New: Fixed [ 1 ]
          Status Original: Open [ 1 ] New: Closed [ 6 ]

          Committed in 5167.

          adama Adam Armstrong added a comment - Committed in 5167.
          moorereason Cameron Moore created issue -

          People

            codekiller Dennis de Houx
            moorereason Cameron Moore
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: