Please allow override for email on certain alert checks

If I corectly understand this patch fully implemented.

But note, after my latest changes there is some changes:

$config['alerts']['email']['default_only'] migrated to $config['email']['default_only']

$config['alerts']['email']['default'] migrated to $config['email']['default']

and now if you set

$config['email']['default_only'] = TRUE;

to TRUE, mails send only to default email address (skipped all syscontact and other contacts from db)

committed

reverted all indenting changes

Thanks, but still not ok:

$update_array['last_message'] = 'Checks failed (Suppressed: '.implode(', ', $suppressed).')';

• $update_array['last_checked'] = time();
  + $update_array['last_checked'] = time();

(and following lines)

Comments can stay indented, too

That didn't really fix the patch. Now there are places where existing indentation has been removed, and indentation which is too large is still too large.

• changed 4 to 2 whitespaces (and will continue to do so in the future
• pass explicit FALSE to alert_notify() in test_mail.php

thanks for your comments sid3windr!

• Please fix the indentation, so the patch isn't so humongous (2 spaces, like the entire file was, is fine, thanks), and we can read what actually changed.
• Did you really mean to pass TRUE as third argument in test_mail.php? If so, why not just put TRUE?

this patch does the following:

• move email specific code from alert_notify() to includes/alerting/email.inc.php
• use a switch statement to invoke email code if there are guys to email, this can be extended to jabber, sms etc
• use the alert_contacts table to look up additional contacts
• clean up alerts.inc.php & improve readability

diff to solve 635

Works for me!