Uploaded image for project: 'Observium'
  1. Observium
  2. OBS-5320

Wrong PHP version in notification

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Major
    • None
    • Professional Edition
    • Web Interface

    Description

      I see an alert notification in Web Interface:

      ./html/includes/notifications.inc.php

      // Admin level notifications on settings/perf pages
      if ($_SESSION['userlevel'] >= 10 && (in_array($vars['tab'], ['data', 'perf', 'edit', 'showtech']) ||
                                           in_array($vars['page'], ['about', 'platform', 'settings', 'preferences']))) {
       
          if (version_compare(PHP_VERSION, OBS_MIN_PHP_VERSION, '<')) {
              $notifications[] = [
                  'text'     => '<h4>Your PHP version is outdate.</h4>
                                 The PHP version you are using <b>' . PHP_MAJOR_VERSION . '.' . PHP_MINOR_VERSION . '.' . PHP_RELEASE_VERSION . '</b>
                                 is older than the minimum required.
                                 Please update PHP to avoid potential incompatibilities and security vulnerabilities.<br/>
                                 Minimum version is <b>' . OBS_MIN_PHP_VERSION . '</b>.<br/>
                                 Recommended version: <b>8.x</b> or later.',
                  'severity' => 'danger',
                  'unixtime' => get_time()
              ];
              if ($config['web_show_notifications']) {
                  $alerts[] = [
                      'title'    => 'PHP version is old',
                      'text'     => 'Your currently installed PHP version <b>' . PHP_MAJOR_VERSION . '.' . PHP_MINOR_VERSION . '.' . PHP_RELEASE_VERSION .
                          "</b> is older than the recommended minimum <b>7.2.x</b>." . "PHP_VERSION=" . PHP_VERSION . "; OBS_MIN_PHP_VERSION=" . OBS_MIN_PHP_VERSION . (version$
                      'severity' => 'alert'
                  ];
              }
          }
      

      The problem is
      my PHP_VERSION=7.3.31-1~deb10u7
      OBS_MIN_PHP_VERSION=7.4.191

      so code compare version with 7.4, but "send message" with comparing to 7.2.x

      Attachments

        Activity

          People

            adama Adam Armstrong
            mtivi Martyushev Tim
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: