Uploaded image for project: 'Observium'
  1. Observium
  2. OBS-505

Location link in map broken if location contains a "/"

Details

    • Bug
    • Resolution: Fixed
    • Minor
    • None
    • None
    • Web Interface
    • irrelevant

    Description

      If a device location contains a "/", the link on the dot in the SVG on the map will contain a non-escaped "/" and hence observium will return an error instead of the list of devices at the location.

      html/pages/front/globe.php

      35 if ($down > 0)

      { 36 $locations_down[] = "['".$location."', 100, '".implode(", ", $devices_down)."']"; 37 }

      else

      { 38 $locations_up[] = "['".$location."', 0, '".implode(", ", $devices_down)."']"; 39 }

      I suppose $location should be escaped.

      Attachments

        Activity

          [OBS-505] Location link in map broken if location contains a "/"

          The URI is now properly escaped, but putting an escaped / in the URI seems to break apache's rewriting.

          Don't put / in locations .

          adama Adam Armstrong added a comment - The URI is now properly escaped, but putting an escaped / in the URI seems to break apache's rewriting. Don't put / in locations .

          globe.php is deprecated, please don't use it.

          adama Adam Armstrong added a comment - globe.php is deprecated, please don't use it.

          People

            adama Adam Armstrong
            roggb Roger Gabarit
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: