Details
-
New Feature
-
Resolution: Incomplete
-
Minor
-
None
-
None
Description
This patch against r4386 adds preliminary support for
monitoring guests running on Proxmox VE platform. Both
OpenVZ containers and KVM virtual machines are supported.
Poller connects to Proxmox node via Proxmox's PVE2 API
and polls stats from all guests on all hosts in a cluster.
Stores RRD files under proxmox subdir for each device.
Included PVE2 API client code used by poller is taken from
https://github.com/CpuID/pve2-api-php-client.
It also adds "Proxmox VE Guests" tab on the device page
that displays CPU, Memory, Disk Usage, Disk I/O and Network
Traffic statistics for each guest.
Attachments
Issue Links
- is cloned by
-
OBS-494 Initial support for Proxmox VE guest monitoring
-
- Open
-
We don't accept code which doesn't conform to our standard conventions for doing things because it unnecessarily decreases the maintainability of the project.
Contributing code to an open source project is like contributing a baby to an orphanage, the future maintenance and updating of the code usually takes more time than it took to write the code in the first place.
We have standard ways of doing things because it makes it quick and easy for us to maintain the code, and for people to debug problems.
You're also gravely mistaken on the performance hit of MySQL queries, particularly this kind of query, and particularly in the context of graph.php.
The whole purpose of graph.php is to fork rrdtool, load one or more RRDs and build a graph, all of which costs at least two orders of magnitude more than the single MySQL lookup to fetch the entity data from the database.
Maintaining a large body of code which is not generally CPU performance bound almost always veers in favour of writing maintainable code rather than sacrificing maintainability in favour of performance.