Details
-
New Feature
-
Resolution: Incomplete
-
Minor
-
None
-
None
Description
This patch against r4386 adds preliminary support for
monitoring guests running on Proxmox VE platform. Both
OpenVZ containers and KVM virtual machines are supported.
Poller connects to Proxmox node via Proxmox's PVE2 API
and polls stats from all guests on all hosts in a cluster.
Stores RRD files under proxmox subdir for each device.
Included PVE2 API client code used by poller is taken from
https://github.com/CpuID/pve2-api-php-client.
It also adds "Proxmox VE Guests" tab on the device page
that displays CPU, Memory, Disk Usage, Disk I/O and Network
Traffic statistics for each guest.
Attachments
Issue Links
- is cloned by
-
-
- Open
-
Activity
Thanks a bunch! I'll keep an eye on other things I might have missed, ofc.
Marko just confirming your patch still works for standalone proxmox installs
I'm generally a Perl coder. PHP is not really my thing, but I'm getting used to it. In Perl, that would make a sound input params check, plus I generally like to be extra careful with input parameters. If you think it is unnecessary, I will remove it.
You are totally right. I have unintentionally discriminated against people running standalone Proxmox servers 
Your fix sounds about right so I've added it to my original patch. It's basically the same as yours, but without duplicated code. I don't have standalone Proxmox to test it on, tho ...
+ // All params passed down from graph.php
+ // have to be defined and valid
+ if (isset($vars['group']) && !empty($vars['group']) &&
+ isset($vars['clustername']) && !empty($vars['clustername']) &&
+ isset($vars['guestid']) && !empty($vars['guestid']) &&
+ isset($vars['guestname']) && !empty($vars['guestname']) &&
+ isset($vars['guesttype']) && !empty($vars['guesttype']))
+ {
Porque?
extended original patch to handle standalone nodes still - rolled against revision 4471
this doesnt work if you have a standalone proxmox node, generating error in discovery.php
Proxmox VE: Failed to get cluster name from host <redacted hostname>
perhaps some fall back is needed to set clustername to the node hostname or similar as the rest of the discovery logic will still work
attaching a patch thats yours rolled against 4471 plus a possible workaround for standalone nodes, i've assumed that if it hasnt failed to login but cluster_name is empty or not existing then it will set cluster name to the device name and proceed with the loop
it could probably done a lot more cleanly without duplicating all that code, but its working for me right now
Disk Usage graph can display disk space in use only for OpenVZ containers. For KVM guests, only total disk size is shown. Proxmox devs said that they plan to introduce an agent that will enable disk usage reporting for KVM guests. That's the reason I chose not to exclude KVM guests from the page.
Data is fetched from "/nodes/<node>/qemu/<vmid>/status/current" and "/nodes/<node>/openvz/<vmid>/status/current" . PVE2 API docs state that both require VM.Auditor privilege.
+ $graph_array['device'] = $device['device_id'];
+ $graph_array['group'] = $group;
+ // - our custom parameters that will be passed to graph.php
+ // and subsequently to our graph generating code when
+ // invoked from <img src="graph.php? ..."/> tag
+ $graph_array['clustername'] = $guest['cluster_name'];
+ $graph_array['guestid'] = $guest['guest_id'];
+ $graph_array['guestname'] = $guest['guest_name'];
+ $graph_array['guesttype'] = $guest['guest_type'];
+ // Generate <img src="graph.php? ..."/> tags on current page
Why are you passing all of this?
Please follow the existing coding style and pass the minimum required to identify the entity. The Observium standard is to pass a database-specific id, with an option to find the id if entity-specific data is passed (see the ports graphs, generally we pass a port_id, but they can also be accessed via ifName or ifIndex)