Uploaded image for project: 'Observium'
  1. Observium
  2. OBS-3740

Syslog pagination incorrect after search

Details

    • Bug
    • Resolution: Cannot Reproduce
    • Minor
    • None
    • Community Edition
    • Web Interface
    • Ubuntu 20.04, Chromium

    Description

      When searching for a text message in syslog, the pagination is incorrect.

      ie. Pagination details is of the full syslog data set.

      So, if you had 400k rows of syslog, after the search you would still have:

      • Result count: 400k
      • Pagination bar shows up to 4000 pages
      • Next button in pagination bar goes to the next set of syslog results (sans search term)

      Attachments

        Activity

          [OBS-3740] Syslog pagination incorrect after search
          route-dist Vuong V added a comment -

          I see. I guess the problem is the full text search on the msg column. OK please close.

          route-dist Vuong V added a comment - I see. I guess the problem is the full text search on the msg column. OK please close.

          You might want to know that, but it doubles the generation time of the page to show that information. We "cheat" when the execution time of the query is >0.5 seconds.

          On my test install it increases the generation time of that page from 15 seconds to 30 seconds.

          adama Adam Armstrong added a comment - You might want to know that, but it doubles the generation time of the page to show that information. We "cheat" when the execution time of the query is >0.5 seconds. On my test install it increases the generation time of that page from 15 seconds to 30 seconds.
          route-dist Vuong V added a comment -

          I can't reproduce the variable reset issue in current code, neither on the /syslog/ page nor the per-device syslog tab.

          Apologies, the pagination bar makes it appear that way. So you are correct the term does not reset. But the pagination bar does not reflect the number of results returned.

          The count being wrong is by design... This is because on large installs generating the count for a full text search will make the interface too slow to use.

          I would argue that generating the count makes the search much more useful. I don't mind a performance hit to know the results of my search.

          Eg. If my syslog was pushing firewall block messages to Observium, and I was searching for a suspect IP address I would want to know how many times they've been attempting to breach the firewall.

          route-dist Vuong V added a comment - I can't reproduce the variable reset issue in current code, neither on the /syslog/ page nor the per-device syslog tab. Apologies, the pagination bar makes it appear that way. So you are correct the term does not reset. But the pagination bar does not reflect the number of results returned. The count being wrong is by design... This is because on large installs generating the count for a full text search will make the interface too slow to use. I would argue that generating the count makes the search much more useful. I don't mind a performance hit to know the results of my search. Eg. If my syslog was pushing firewall block messages to Observium, and I was searching for a suspect IP address I would want to know how many times they've been attempting to breach the firewall.

          I can't reproduce the variable reset issue in current code, neither on the /syslog/ page nor the per-device syslog tab.

          The count being wrong is by design, we abort the query that generates the count if it takes more than 500ms and just use the total table count as a placeholder. This is because on large installs generating the count for a full text search will make the interface too slow to use.

          adama Adam Armstrong added a comment - I can't reproduce the variable reset issue in current code, neither on the /syslog/ page nor the per-device syslog tab. The count being wrong is by design, we abort the query that generates the count if it takes more than 500ms and just use the total table count as a placeholder. This is because on large installs generating the count for a full text search will make the interface too slow to use.

          People

            adama Adam Armstrong
            route-dist Vuong V
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: