Error in Syslog IP->Device_id matching

Syslog lines are not matched to devices by ip address. I dont know since when.

But the problem is, that you are using 

$rows = mysqli_fetch_all($result, MYSQLI_ASSOC);

in the 

function dbFetchRows($sql, $parameters = array(), $print_query = FALSE)

in mysqli.inc.php.

PHP Documentation says: 

syslog.inc.php says:

$query = 'SELECT * FROM `ipv'.$ip_version.'_addresses` LEFT JOIN `ports` USING (`port_id`) WHERE `ipv'.$ip_version.'_address` = ? AND (`deleted` = ? OR `deleted` IS NULL);';

The problem: After joining the two tables, there are 2 device_id fields - so i think PHP is using the last field (from table ports) where device_id is NULL. So even if the first device_id field contains a value, PHP sets the value to NULL.

So we need to adjust the query to:

$query = 'SELECT `ipv'.$ip_version.'_addresses`.device_id, ports.ifAdminStatus, ports.ifOperStatus FROM `ipv'.$ip_version.'_addresses` LEFT JOIN `ports` USING (`port_id`) WHERE `ipv'.$ip_version.'_address` = ? AND (`deleted` = ? OR `deleted` IS NULL);';

Example:

MariaDB [observium]> SELECT ipv4_addresses.device_id FROM `ipv4_addresses` LEFT JOIN `ports` USING (`port_id`) WHERE `ipv4_address` = '10.49.50.20' AND (`deleted` = '0' OR `deleted` IS NULL);
-----------

-----------

-----------
1 row in set (0.00 sec)

MariaDB [observium]> SELECT device_id FROM `ipv4_addresses` LEFT JOIN `ports` USING (`port_id`) WHERE `ipv4_address` = '10.49.50.20' AND (`deleted` = '0' OR `deleted` IS NULL);
ERROR 1052 (23000): Column 'device_id' in field list is ambiguous

After this change the syslog entries are stored for the correct device!

Patch is attached...

I hope you understand the problem..