Uploaded image for project: 'Observium'
  1. Observium
  2. OBS-3187

IPMI chassis en power supply support

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Major
    • None
    • Professional Edition
    • Unix Agent

    Description

      The function parse_ipmitool_sensor() is not working correctly due to the empty discrete value in includes/definitions/entities/sensors.inc.php.

      The following statements in parse_ipmitool_sensor() (includes/entities/sensor.inc.php) returns true if the $unit is discrete:

      if (isset($config['ipmi_unit'][$unit])) {
      

      and the code below (from OBS-3028) will never run:

      } elseif ($unit == 'discrete') {
      

      because an empty value is set in the array, so isset() returns true.

      The attached patch will remove empty value from the array. Another option could be checking is there is an actual value in the unit-array:

      if (isset($config['ipmi_unit'][$unit]) && $config['ipmi_unit'][$unit]) {
      

      Attachments

        1. ipmi_discrete.diff
          0.5 kB
          Bernard van der Velden
        2. ipmi_patch_bernard.diff
          4 kB
          Bernard van der Velden
        3. ipmi_patch_rework.diff
          4 kB
          Bernard van der Velden
        4. ipmi_sensors.diff
          3 kB
          Andrew Bonney
        5. ipmi_sensors.diff
          3 kB
          Andrew Bonney
        6. ipmitool-sdr-r730.txt
          69 kB
          Andrew Bonney
        7. ipmitool-sensors-r730.txt
          21 kB
          Andrew Bonney
        8. poller_patched.log
          115 kB
          Bernard van der Velden
        9. poller.log
          111 kB
          Bernard van der Velden
        10. poller-r730.txt
          329 kB
          Andrew Bonney

        Issue Links

          Activity

            People

              landy Mike Stupalov
              veldenb Bernard van der Velden
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: