Details
-
Bug
-
Resolution: Unresolved
-
Minor
-
None
-
Professional Edition
-
None
Description
Device API currently displays [devices][id][location], which is the snmp location. Request to add lat/lon to this, which is already present in sql in observium.devices_locations.latitutde and longitude.
This table is already left joined in a query in:
./html/api/v0/includes/devices.inc.php
.. but I don't think this is actually doing anything as the location listed is already in the devices table.
It looks like it's checking for $config['geocoding']['enable'] within the api_get_devices() function, but it's not getting $config passed so it's always a FALSE.
if config were passed via this line:
Flight::route('GET /devices', 'api_get_devices');
it would probably solve this. I'm unfamiliar with Flight::route so It wasn't straightforward to me how to pass this. I tried to change the last part of api_get_devices to api_get_devices($config) but it did not enjoy it.
Attachments
Activity
Probably just "global $config;" in the function body should suffice.
It appears that one can change these lines:
Flight::route('GET /devices', api_get_devices($config));
function api_get_devices($config)
.. and it does work. it however involves removing single ticks from 'api_get_devices' on the first line, which may break other stuff.
It is probably the best way of handling the config, either that or $GLOBALS['config'].
I think the former is slightly faster though.