Details
-
Improvement
-
Resolution: Fixed
-
Minor
-
None
-
Professional Edition
Description
Hi there,
Please excuse any mistakes Ive made in logging this request, I'm not very familiar with this project or Jira general practises.
Ive made some modifications to my obs instance;
- fix average / red line dropping to zero at the right end of the graph
- colour the average line based on packet loss threshold
- colour the background based on packet loss threshold
- draw packet loss thresholds on legend
- annotate legend with number of probes/interval etc
- updated loss average for period to display with 3 decimal places
All changes are within this file "./observium/html/includes/graphs/device/smokeping_all_common_avg.inc.php" and I have attached my new/modified version of the file with comments
I was hoping this could be reviewed and possibly integrated into mainline to enhance for all users using smokeping integration 
Cheers,
Matt
Attachments
Issue Links
- mentions
-
OBS-1257 One more patch for Smokeping
-
- Reopened
-
Activity
Adam, thank you too!
Matt, from my standpoint, the only feature to be added after your improvement is graphing the same target from multiple Smokeping instances. It's a broad practice for big ISPs to monitor their devices from several places, like monitoring a router in Paris from Smokeping instances in London, Amsterdam and Frankfurt.
Thanks for your kind words Sergey
We do live in hope with regard to better smokeping integration for Obs I was really hoping that given the minor amendments required to improve the existing graphs that this enhancement might get picked up and integrated.
I dont understand the process here or community particularly well, is there anything else I can do to help move this along?
Cheers, Matt
Nice job, Matt!
It would be great if Smokeping code would eventually get committed to Observium.
It was a long-time awaited feature, OBS-1257 was a similar implementation and was even committed, but unfortunately rolled back.
Tengo un informe, estoy trabajando en el desarrollo de informes en la nube para observar, estoy interesado en darme cuenta de las apreciaciones que me gusta extraer de Observium.
I have a report, I am working on a development of reporting in the cloud to observe, I am interested in realizing the appreciations that I like to extract from Observium
Thanks. I believe there is a small problem with this patch. It works fine when there is only one iteration of the loop ($i variable), for example, "target" servers are pinged from a single "source" server and one wants to examine smokeping_in_all_avg chart of each "target" server.
However, when one wants to examine smokeping_out_all_avg of a "source" server, one gets error "RRDTool Output: ERROR: trying to reuse vname me0." Apparently, when there are multiple "target" servers, the loop ($i variable) is executed multiple times and me$lvar and other variables cannot be reused and rrdtool fails.
Any chance for a fix?