Details

    • Bug
    • Resolution: Unresolved
    • Minor
    • None
    • Community Edition
    • Unix Agent

    Description

      I'm attaching fixes for mysql and hddtemp based on version 17.9.0

      mysql: did not show innodb graphs since last year due to innodb status output change

      hddtemp: for some disks, hddtemp outputs \x10\x80 at the end of name column which causes observium to constantly update name and spam event log every 5 minutes

      Attachments

        1. hddtemp
          0.4 kB
        2. mysql
          55 kB

        Activity

          [OBS-2720] unix agent script fixes

          I don't have any devices which do this. Can you test if : 

          $agent_data['hddtemp'] = str_replace("\x10\x80", '', $agent_data['hddtemp']);

          in includes/polling/unix-agent/hddtemp.inc.php removes this character properly (obviously after removing your change from the agent script!)?

          adama Adam Armstrong added a comment - I don't have any devices which do this. Can you test if :  $agent_data ['hddtemp'] = str_replace("\x10\x80", '', $agent_data ['hddtemp'] ); in includes/polling/unix-agent/hddtemp.inc.php removes this character properly (obviously after removing your change from the agent script!)?

          I suppose it doesn't matter since people don't really update their agent scripts!

          adama Adam Armstrong added a comment - I suppose it doesn't matter since people don't really update their agent scripts!
          Tomaa Tomas added a comment -

          character removal is indeed better in php if you want to do that. I updated script because it was faster and it is easier to keep up to date when updating observium versions.

          Sorry, I'm not able to confirm compatibility with those very old versions.

          Tomaa Tomas added a comment - character removal is indeed better in php if you want to do that. I updated script because it was faster and it is easier to keep up to date when updating observium versions. Sorry, I'm not able to confirm compatibility with those very old versions.

          the hddtemp removal is better done in php, since it won't require people to update agent scripts (which is fiddly).

          will the mysql changes break older versions, or will both old and new work now?

          adama Adam Armstrong added a comment - the hddtemp removal is better done in php, since it won't require people to update agent scripts (which is fiddly). will the mysql changes break older versions, or will both old and new work now?

          People

            sid3windr Tom Laermans
            Tomaa Tomas
            Votes:
            1 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated: