Uploaded image for project: 'Observium'
  1. Observium
  2. OBS-2140

Multiport graphs are always shows even when $config[\'allow_unauth_graphs\'] is not set

Details

    • Bug
    • Resolution: Fixed
    • Minor
    • None
    • Community Edition, Professional Edition
    • Web Interface

    Description

      File

      html/includes/graphs/multi-port/auth.inc.php

      When $config['allow_unauth_graphs'] is not set, $auth should be set depending if the user is logged in and allowed to view the ports data.

      In the mentioned auth.inc file $auth is always set to TRUE ( I guess to make things work.) and then it loops over all the ports to check if the user is allowed to see the info.

      Attached patch file will set an additional status-variable while looping over the ports. At the end $auth is updated with the results of the loop.

      You might want to check if $auth is (already) set to TRUE before looping over the ports, as $auth would not change if it is already set to TRUE.

      Attachments

        Activity

          [OBS-2140] Multiport graphs are always shows even when $config[\'allow_unauth_graphs\'] is not set

          Committed in r8302. Thanks!

          adama Adam Armstrong added a comment - Committed in r8302. Thanks!

          Seems someone needs to learn to make a correct patch file ...
          The original file was the output of the regular diff... but I had the old and new file reversed...

          I've deleted the old file and added a unified patch-file... hope this helps...

          cya

          osv Sven Van Den Steene added a comment - Seems someone needs to learn to make a correct patch file ... The original file was the output of the regular diff... but I had the old and new file reversed... I've deleted the old file and added a unified patch-file... hope this helps... cya

          What format is this patch in?

          adama Adam Armstrong added a comment - What format is this patch in?

          People

            adama Adam Armstrong
            osv Sven Van Den Steene
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: