Details

    Description

      The usual

      Attachments

        Activity

          [OBS-1700] HTML fixes and improvements

          Hi Mike

          1) Labels is what is used elsewhere in the code
          2) Badges have rounded corners, which is not inline with current UI

          kentbjoh Kent Johannessen added a comment - Hi Mike 1) Labels is what is used elsewhere in the code 2) Badges have rounded corners, which is not inline with current UI

          Why you replaced 'badge' by 'label'?

          landy Mike Stupalov added a comment - Why you replaced 'badge' by 'label'?

          Fixed. I blame tortoisesvn :=)

          kentbjoh Kent Johannessen added a comment - Fixed. I blame tortoisesvn :=)

          root@omega:/home/observium/dev# patch -p0 < htmlfixesv7_v2.patch
          (Stripping trailing CRs from patch; use --binary to disable.)
          patching file html/includes/entities/mempool.inc.php
          Hunk #1 FAILED at 105 (different line endings).
          Hunk #2 FAILED at 172 (different line endings).
          2 out of 2 hunks FAILED – saving rejects to file html/includes/entities/mempool .inc.php.rej
          (Stripping trailing CRs from patch; use --binary to disable.)
          patching file html/includes/entities/port.inc.php
          (Stripping trailing CRs from patch; use --binary to disable.)
          patching file html/includes/entities/processor.inc.php
          Hunk #1 FAILED at 93 (different line endings).
          Hunk #2 FAILED at 150 (different line endings).
          2 out of 2 hunks FAILED – saving rejects to file html/includes/entities/process or.inc.php.rej
          (Stripping trailing CRs from patch; use --binary to disable.)
          patching file html/includes/entities/storage.inc.php
          Hunk #1 FAILED at 105 (different line endings).
          Hunk #2 FAILED at 159 (different line endings).
          2 out of 2 hunks FAILED – saving rejects to file html/includes/entities/storage .inc.php.rej
          (Stripping trailing CRs from patch; use --binary to disable.)
          patching file html/includes/entities/toner.inc.php
          Hunk #1 FAILED at 85 (different line endings).
          Hunk #2 FAILED at 98 (different line endings).
          Hunk #3 FAILED at 148 (different line endings).
          3 out of 3 hunks FAILED – saving rejects to file html/includes/entities/toner.i nc.php.rej
          (Stripping trailing CRs from patch; use --binary to disable.)
          patching file html/includes/print/dot1xtable.inc.php
          (Stripping trailing CRs from patch; use --binary to disable.)
          patching file html/includes/print/rows.inc.php
          (Stripping trailing CRs from patch; use --binary to disable.)
          patching file html/pages/about.inc.php
          (Stripping trailing CRs from patch; use --binary to disable.)
          patching file html/pages/alert_check.inc.php

          However you're generating the patch isn't quite right. I think you just made a horrible mess of my dev install

          adama Adam Armstrong added a comment - root@omega:/home/observium/dev# patch -p0 < htmlfixesv7_v2.patch (Stripping trailing CRs from patch; use --binary to disable.) patching file html/includes/entities/mempool.inc.php Hunk #1 FAILED at 105 (different line endings). Hunk #2 FAILED at 172 (different line endings). 2 out of 2 hunks FAILED – saving rejects to file html/includes/entities/mempool .inc.php.rej (Stripping trailing CRs from patch; use --binary to disable.) patching file html/includes/entities/port.inc.php (Stripping trailing CRs from patch; use --binary to disable.) patching file html/includes/entities/processor.inc.php Hunk #1 FAILED at 93 (different line endings). Hunk #2 FAILED at 150 (different line endings). 2 out of 2 hunks FAILED – saving rejects to file html/includes/entities/process or.inc.php.rej (Stripping trailing CRs from patch; use --binary to disable.) patching file html/includes/entities/storage.inc.php Hunk #1 FAILED at 105 (different line endings). Hunk #2 FAILED at 159 (different line endings). 2 out of 2 hunks FAILED – saving rejects to file html/includes/entities/storage .inc.php.rej (Stripping trailing CRs from patch; use --binary to disable.) patching file html/includes/entities/toner.inc.php Hunk #1 FAILED at 85 (different line endings). Hunk #2 FAILED at 98 (different line endings). Hunk #3 FAILED at 148 (different line endings). 3 out of 3 hunks FAILED – saving rejects to file html/includes/entities/toner.i nc.php.rej (Stripping trailing CRs from patch; use --binary to disable.) patching file html/includes/print/dot1xtable.inc.php (Stripping trailing CRs from patch; use --binary to disable.) patching file html/includes/print/rows.inc.php (Stripping trailing CRs from patch; use --binary to disable.) patching file html/pages/about.inc.php (Stripping trailing CRs from patch; use --binary to disable.) patching file html/pages/alert_check.inc.php However you're generating the patch isn't quite right. I think you just made a horrible mess of my dev install

          updated patch with some more ui fixes

          kentbjoh Kent Johannessen added a comment - updated patch with some more ui fixes

          People

            adama Adam Armstrong
            kentbjoh Kent Johannessen
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: