Details

    Description

      Several fixes in html for new design.
      Also fixes a couple sorting bugs in ports page.
      Use of generate_query_values function in several pages.
      Added known/unknown sorting in neighbours page.

      Attachments

        Activity

          [OBS-1625] HTML fixes and improvements

          Nice fixes as usual, thanks!

          Committed in r7354.

          adama Adam Armstrong added a comment - Nice fixes as usual, thanks! Committed in r7354.

          fixed by :

          sed -i -e 's/\r$//g'

          On file and patch. Thanks google.

          adama Adam Armstrong added a comment - fixed by : sed -i -e 's/\r$//g' On file and patch. Thanks google.

          I'm not sure what is causing this :

          root@omega:/home/observium/dev# patch -p0 < htmlfixesv6.patch
          (Stripping trailing CRs from patch; use --binary to disable.)
          patching file html/includes/entities/port.inc.php
          Hunk #1 FAILED at 264 (different line endings).
          Hunk #2 FAILED at 270 (different line endings).
          Hunk #3 FAILED at 324 (different line endings).
          Hunk #4 FAILED at 353 (different line endings).
          Hunk #5 FAILED at 398 (different line endings).
          Hunk #6 FAILED at 459 (different line endings).
          Hunk #7 FAILED at 473 (different line endings).
          Hunk #8 FAILED at 493 (different line endings).
          Hunk #9 FAILED at 521 (different line endings).
          Hunk #10 FAILED at 566 (different line endings).
          Hunk #11 FAILED at 626 (different line endings).
          Hunk #12 FAILED at 645 (different line endings).
          Hunk #13 FAILED at 669 (different line endings).
          Hunk #14 FAILED at 685 (different line endings).
          Hunk #15 FAILED at 695 (different line endings).
          Hunk #16 FAILED at 709 (different line endings).
          Hunk #17 FAILED at 726 (different line endings).
          Hunk #18 FAILED at 735 (different line endings).
          Hunk #19 FAILED at 750 (different line endings).
          19 out of 19 hunks FAILED – saving rejects to file html/includes/entities/port.inc.php.rej

          adama Adam Armstrong added a comment - I'm not sure what is causing this : root@omega:/home/observium/dev# patch -p0 < htmlfixesv6.patch (Stripping trailing CRs from patch; use --binary to disable.) patching file html/includes/entities/port.inc.php Hunk #1 FAILED at 264 (different line endings). Hunk #2 FAILED at 270 (different line endings). Hunk #3 FAILED at 324 (different line endings). Hunk #4 FAILED at 353 (different line endings). Hunk #5 FAILED at 398 (different line endings). Hunk #6 FAILED at 459 (different line endings). Hunk #7 FAILED at 473 (different line endings). Hunk #8 FAILED at 493 (different line endings). Hunk #9 FAILED at 521 (different line endings). Hunk #10 FAILED at 566 (different line endings). Hunk #11 FAILED at 626 (different line endings). Hunk #12 FAILED at 645 (different line endings). Hunk #13 FAILED at 669 (different line endings). Hunk #14 FAILED at 685 (different line endings). Hunk #15 FAILED at 695 (different line endings). Hunk #16 FAILED at 709 (different line endings). Hunk #17 FAILED at 726 (different line endings). Hunk #18 FAILED at 735 (different line endings). Hunk #19 FAILED at 750 (different line endings). 19 out of 19 hunks FAILED – saving rejects to file html/includes/entities/port.inc.php.rej

          People

            adama Adam Armstrong
            kentbjoh Kent Johannessen
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: