Uploaded image for project: 'Observium'
  1. Observium
  2. OBS-1483

Better Graph view on Global Ports page

Details

    Description

      This patch brings better graph view to global ports page. It now looks like other port pages around the system.
      Current graphs view does not respect pagination, and if you have many ports it will likely freeze your browser, or worse kill your apache.

      File /opt/observium/html/pages/ports/graphs.inc.php can also be deleted, but I did not include that in the patch.

      Pics for comparison.

      Attachments

        1. ports_new.PNG
          ports_new.PNG
          123 kB
        2. ports_old.PNG
          ports_old.PNG
          82 kB
        3. ports_better_graphs.patch
          2 kB

        Activity

          [OBS-1483] Better Graph view on Global Ports page
          adama Adam Armstrong added a comment -

          committed in 7058

          adama Adam Armstrong added a comment - committed in 7058
          adama Adam Armstrong added a comment -

          the other format should probably retained as "minigraphs", as is done with devices, and perhaps cleaned up.

          If you get bored

          adama Adam Armstrong added a comment - the other format should probably retained as "minigraphs", as is done with devices, and perhaps cleaned up. If you get bored
          adama Adam Armstrong added a comment -

          $vars!

          adama Adam Armstrong added a comment - $vars!
          kentbjoh Kent Johannessen added a comment -

          Ofc I see the issue. Need too look at all my environments Sorry, new patch aboard.

          kentbjoh Kent Johannessen added a comment - Ofc I see the issue. Need too look at all my environments Sorry, new patch aboard.
          adama Adam Armstrong added a comment -

          There was no change between it and the non-graphs output.

          adama Adam Armstrong added a comment - There was no change between it and the non-graphs output.
          kentbjoh Kent Johannessen added a comment -

          Testing is always nice :] How did it show for you?

          kentbjoh Kent Johannessen added a comment - Testing is always nice :] How did it show for you?
          adama Adam Armstrong added a comment -

          This seems to have entirely broken the graphs output. I should have tested it before i committed it! gah!

          adama Adam Armstrong added a comment - This seems to have entirely broken the graphs output. I should have tested it before i committed it! gah!

          People

            adama Adam Armstrong
            kentbjoh Kent Johannessen
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: