Uploaded image for project: 'Observium'
  1. Observium
  2. OBS-1020

Add APC InRow (Gen 2) support

Details

    • Improvement
    • Resolution: Fixed
    • Minor
    • None
    • None
    • Discovery

    Description

      Please add support for APC Inrow (Gen 2) devices. I have attached a patch for this. Tested with a few air cooled APC InRow RD (ACRD101) in a group setup.

      You might want to separate APS's power- and cooling (and Netbotz, etc.) devices at a later time, so device types will be discovered correctly ("power" or "environment"), and separate the discovery file to avoid a mix of several types of devices.

      Attachments

        Activity

          [OBS-1020] Add APC InRow (Gen 2) support
          sid3windr Tom Laermans added a comment -

          Committed somewhat in r6186.

          sid3windr Tom Laermans added a comment - Committed somewhat in r6186.
          sid3windr Tom Laermans added a comment -

          You added a fake "POWERNET-INROW-MIB" definition, then poll PowerNet-MIB from inside that file? Makes no sense.

          sid3windr Tom Laermans added a comment - You added a fake "POWERNET-INROW-MIB" definition, then poll PowerNet-MIB from inside that file? Makes no sense.
          landy Mike Stupalov added a comment -

          Currently we not want to separate APC InRow and any other APC model, because APC uses generic MIB for any device type.

          You can just add additional MIB to discovery for additional models (powernet-inrow-mib.inc.php).
          And device type can changed in 'os' poller module.

          landy Mike Stupalov added a comment - Currently we not want to separate APC InRow and any other APC model, because APC uses generic MIB for any device type. You can just add additional MIB to discovery for additional models (powernet-inrow-mib.inc.php). And device type can changed in 'os' poller module.
          japs Japs added a comment -

          Yea, the current one only supports APC InRow RC models. Each model type has a different prefix in the SNMP tree (you've gotta love them), so I've also added the prefixes for the RP, SC and RD models.

          As the InRows don't match any other checks during the discovery, I've removed the InRow checks from the current (mostly power-related) discovery check and separated it in it's own file powernet-inrow-mib.inc.php), and added it as it's own OS ("apcinrow").

          The current patch is still compatible with the latest release (r5876 currently).

          japs Japs added a comment - Yea, the current one only supports APC InRow RC models. Each model type has a different prefix in the SNMP tree (you've gotta love them), so I've also added the prefixes for the RP, SC and RD models. As the InRows don't match any other checks during the discovery, I've removed the InRow checks from the current (mostly power-related) discovery check and separated it in it's own file powernet-inrow-mib.inc.php), and added it as it's own OS ("apcinrow"). The current patch is still compatible with the latest release (r5876 currently).
          adama Adam Armstrong added a comment -

          IS this different to what's in now? does it apply against latest?

          adama Adam Armstrong added a comment - IS this different to what's in now? does it apply against latest?
          japs Japs added a comment -

          I've separated the APC InRows, to keep the code a bit cleaner (and faster). I've also added support for additional InRow models (supported: APC InRow RC, RP, SC, RD).

          japs Japs added a comment - I've separated the APC InRows, to keep the code a bit cleaner (and faster). I've also added support for additional InRow models (supported: APC InRow RC, RP, SC, RD).

          People

            sid3windr Tom Laermans
            japs Japs
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: