PHP fatal errors at device discovery and alert rebuild

Ilkka Myller added a comment - 2021/04/28 07:29 AM "To err is human, but for a real disaster you need a computer."  I can confirm this issue fixed in r11275. Thank you for quick response and fix.    

Adam Armstrong added a comment - 2021/04/27 06:20 PM Yeah, this was me rushing a stable merge to fix another bug, and introducing some errant debugging code. Whoops! Should be fixed now.

Mark Williams added a comment - 2021/04/27 05:58 PM Getting the same issue after svn update.

Ilkka Myller added a comment - 2021/04/27 10:47 AM - edited The problematic lines were introduced in revs r11253 -> r11262: ------------------------------------------------------------------------ r11262 | adama | 2021-04-26 03:34:03 +0300 (Mon, 26 Apr 2021) | 2 lines   [STABLE] Merge of r11253 through r11261   ------------------------------------------------------------------------ r11253 | adama | 2021-04-21 17:19:50 +0300 (Wed, 21 Apr 2021) | 2 lines   [STABLE] Stable merge of r11172 through r11252.    With diff:   observium:/opt/observium# svn diff -r 11253   includes/alerts.inc.php  Index: includes/alerts.inc.php =================================================================== --- includes/alerts.inc.php (revision 11253 ) +++ includes/alerts.inc.php (working copy) @@ - 424 , 10 + 424 , 15 @@     {          $query = parse_qb_ruleset($alert[ 'entity_type' ], safe_json_decode($alert[ 'alert_assoc' ])); + +r($query); +        $data  = dbFetchRows($query);        //$error = dbError();        $entities = array();   +r($data); +        $field = $GLOBALS[ 'config' ][ 'entities' ][$alert[ 'entity_type' ]][ 'table_fields' ][ 'id' ];          foreach($data as $datum) @@ - 443 , 9 + 448 , 10 @@    

Ilkka Myller added a comment - 2021/04/27 10:39 AM There seems to be couple of incorrectly formatted lines (bad code indentation) in alerts.inc.php: r($query); r($data); Could this be result of a bad code merge? My svn status is clean and local repo is in sync with the stable Observium Pro repository —     function update_alert_table($alert, $silent = TRUE) {        if (is_numeric($alert)) // We got an alert_test_id, fetch the array.    {       $alert = dbFetchRow( "SELECT * FROM `alert_tests` WHERE `alert_test_id` = ?" , array($alert));    }        if (strlen($alert[ 'alert_assoc' ]))    {           $query = parse_qb_ruleset($alert[ 'entity_type' ], safe_json_decode($alert[ 'alert_assoc' ]));     r($query);           $data  = dbFetchRows($query);       //$error = dbError();       $entities = array();     r($data);           $field = $GLOBALS[ 'config' ][ 'entities' ][$alert[ 'entity_type' ]][ 'table_fields' ][ 'id' ];           foreach($data as $datum)       {          $entities[$datum[$field]] = array( 'entity_id' => $datum[$field], 'device_id' => $datum[ 'device_id' ]);       }        } else {       $entities = get_alert_entities_from_assocs($alert);    }             $data  = dbFetchRows($query);       //$error = dbError();       $entities = array();     r($data);           $field = $GLOBALS[ 'config' ][ 'entities' ][$alert[ 'entity_type' ]][ 'table_fields' ][ 'id' ];           foreach($data as $datum)       {          $entities[$datum[$field]] = array( 'entity_id' => $datum[$field], 'device_id' => $datum[ 'device_id' ]);       }        } else {       $entities = get_alert_entities_from_assocs($alert);    }