Uploaded image for project: 'Observium'
  1. Observium
  2. OBS-3518

Patch: Add Eltek OIDs RectifierTotalCurrent and RectifierUtilization

Details

    • Improvement
    • Resolution: Fixed
    • Minor
    • None
    • Community Edition
    • Discovery
    • None

    Description

      Hi All,

      Just wanted to submit a patch I created which adds support for two additional fields from Eltek Power Systems supported already by the `../observium/includes/discovery/sensors/eltek-distributed-mib.inc.php` file. I talked to @FrogOfWar on your discord and he told me to post it here in an issue with a pastebin.

      This patch adds support for the fields:

      • Current - `RectifierTotalCurrent` (A)
      • Load - `RectifierUtilization` (%)

      File: `/opt/observium/includes/discovery/sensors/eltek-distributed-mib.inc.php`

      Source: https://pastebin.com/ZZG0NkDB

      Attachments

        Activity

          [OBS-3518] Patch: Add Eltek OIDs RectifierTotalCurrent and RectifierUtilization
          bot Observium Bot made changes -
          Status Original: Resolved [ 5 ] New: Closed [ 6 ]
          landy Mike Stupalov added a comment -

          Ok, scale fixed in r10808.

          landy Mike Stupalov added a comment - Ok, scale fixed in r10808.
          ndom91 Nico Domino made changes -
          Attachment New: image-2020-11-05-11-54-44-535.png [ 17975 ]
          ndom91 Nico Domino added a comment - - edited

          What do you mean by "we prefer definitions" exactly?

          The current scaling by 0.1 is actually incorrect on this device. I had to remove that in my local version to get accurate current readings. Sorry different device, total current is correct though without the 0.1 scaling, for example:

          ndom91 Nico Domino added a comment - - edited What do you mean by "we prefer definitions" exactly? The current scaling by 0.1 is actually incorrect on this device. I had to remove that in my local version to get accurate current readings. Sorry different device, total current is correct though without the 0.1 scaling, for example:
          landy Mike Stupalov made changes -
          Issue Type Original: Library Bug [ 10100 ] New: Improvement [ 4 ]
          Resolution New: Fixed [ 1 ]
          Status Original: In Progress [ 3 ] New: Resolved [ 5 ]
          landy Mike Stupalov added a comment -

          Added in r10807.

          But we prefer definitions, revert your changes in file:

          svn revert includes/discovery/sensors/eltek-distributed-mib.inc.php

          And as described in mib file, current should be scaled by 0.1.

          landy Mike Stupalov added a comment - Added in r10807. But we prefer definitions, revert your changes in file: svn revert includes/discovery/sensors/eltek-distributed-mib.inc.php And as described in mib file, current should be scaled by 0.1.
          landy Mike Stupalov made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]
          ndom91 Nico Domino added a comment -

          The source file linked in the description is the source for the entire file, here's a diff patch for the changes specifically:

          https://pastebin.com/7C39NzuP

          Thanks,
          Nico

          ndom91 Nico Domino added a comment - The source file linked in the description is the source for the entire file, here's a diff patch for the changes specifically: https://pastebin.com/7C39NzuP Thanks, Nico
          ndom91 Nico Domino created issue -

          People

            landy Mike Stupalov
            ndom91 Nico Domino
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: